Mick (Customer) asked a question.

September 10, 2025 at 3:11 PM
having trouble with code recognizing switch closures and going to subroutines. serial monitor recognizes state changes with switches... thanks
  1. rev 1.00 08/20/2025 7:03 AM -initial release
  3.  
  4. */
  5. #include <P1AM.h>
  6. void setup() { // the setup routine runs once:
  7. Serial.begin(9600); //initialize serial communication at 115200 bits per second
  8. while (!P1.init()){
  9. ; //wait for Modules to sign on
  10. }
  11. }
  12. /*
  13. I/O assignments and Slot assignments
  14. * *********************************************************************************************
  15.  
  16. * *********************************************************************************************
  17. labels for outputs SLOT-1 P1-15TD2 OUTPUT MODULE 15 points of OUTPUT
  18. */
  19. //channelLabel N/A = {1, 1}; // SLOT-1 - CH-1: N/A
  20. channelLabel doorUPrelay = {1, 1}; // SLOT-1 - CH-1: doorUPrelay control relay 1=doorUP / 0=NOT-doorUP
  21. channelLabel doorDOWNrelay = {1, 2}; // SLOT-1 - CH-2: doorDOWNrelay control relay 1=doorDOWN / 0=NOT-doorDOWN
  22. channelLabel GREENlight = {1, 12}; // SLOT-1 - CH-12: green light control 1=on / 0= off
  23. channelLabel AMBERlight = {1, 13}; // SLOT-1 - CH-13: amber light control 1=on / 0= off
  24. channelLabel REDlight = {1, 14}; // SLOT-1 - CH-14: red light control 1=on / 0= off
  25. //channelLabel N/A = {1, 15}; // SLOT-1 - CH-15: N/A
  26. /* ********************************************************************************************
  27. labels for inputs SLOT-2 P2-16ND3 INPUT MODULE 16 points of INPUT
  28. */
  29. channelLabel SAFEdoorSWITCH = {2, 1}; // SLOT-2 - CH-1: safety door interlock switch 1=safe / 0= not-safe
  30. channelLabel STOPcommandSWITCH = {2, 2}; // SLOT-2 - CH-3: door motion stop switch 1=not-door-stop motion/ 0=stop door motion
  31. channelLabel UPcommandSWITCH = {2, 3}; // SLOT-2 - CH-2: UPcommandSWITCH door UP mode switch 1=NOT-door-UP / 0= door-UP
  32. channelLabel DOWNcommandSWITCH = {2, 4}; // SLOT-2 - CH-4: DOWNcommandSWITCH door DOWN mode switch 1=NOT-door-DOWN / 0= door-DOWN
  33.  
  34. /* ********************************************************************************************
  35. // * *********************************************************************************************
  36. /*
  37. /*
  38. labels for analog input SLOT-2 P1-04AD-2 ANALOG INPUT MODULE 4-CHANNEL of 0-10 VDC INPUT
  39. */
  40. // channelLabel N/A = {2, 1}; // SLOT-1 - CH-1: N/A
  41. // ********************************************************************************************
  42. // system variables / flags
  43. //
  44. //int UPcommandSWITCH = 1; // check if UPcommandSWITCH flag = 1 NOT-UPcommandSWITCH / 0=UPcommandSWITCH
  45. //int DOWNcommandSWITCH = 1; // check if DOWNcommandSWITCH flag = 1 NOT-DOWNcommandSWITCH / 0=DOWNcommandSWITCH
  46. //int STOPdoorSWITCH = 1; // check if STOPdoorSWITCH flag = 1 NOT-STOPdoorSWITCH / 0=STOPdoorSWITCH
  47. int UPDOORmode = 1; // check if UPDOORmode flag = 1 NOT- door up / 0= door up
  48. int DOWNDOORmode = 1; // check if DOWNDOORmode flag = 1 NOT- door down / 0= door down
  49. int STOPDOORmode = 1; // check if STOPDOORmode flag = 1 NOT- door stop / 0= door stop
  50. int FAULTfatal = 0; // set FAULTfatal flag = 0 not in FAULT / 1= FAULT "int" global variable
  51. int AMBERLIGHT = 0;
  52. int REDLIGHT = 0;
  53. int GREENLIGHT = 0;
  54. unsigned long x = 0; // the time the delay started
  55.  
  56. // ********************************************************************************
  57. /* *********************************************************************************************
  58. * scan UP/DOWN control switch zone
  59. */
  60. void loop() // the loop routine to scan UP/DOWN control switch zone
  61. { scanCONTROLbuttons();
  62. }
  63. void scanCONTROLbuttons()
  64. {
  65. Serial.println(UPDOORmode); // check status if x-axis has homed
  66. P1.writeDiscrete(HIGH, GREENlight); //green light control= ON
  67. delay(250); //wait .25 second
  68. //P1.writeDiscrete(HIGH,doorUPrelay); // doorUPrelay control relay 1=doorUP / 0=NOT-doorUP
  69. //P1.writeDiscrete(HIGH,doorDOWNrelay); // doorUPrelay control relay 1=doorDOWN / 0=NOT-doorDOWN
  70. //
  71. // check UP door Switch for status: = 1 NOT-UPcommandSWITCH / 0=UPcommandSWITCH
  72. UPDOORmode = P1.readDiscrete(UPcommandSWITCH); // check if UPcommandSWITCH = 1 NOT-UPcommandSWITCH / 0=UPcommandSWITCH
  73. if (UPDOORmode == 1) // check if UPDOORmode flag = 1 NOT- door up / 0= door up
  74. {
  75. // P1.writeDiscrete(HIGH,doorUPrelay); // doorUPrelay control relay 1=doorUP / 0=NOT-doorUP
  76. MOVEdoorUP; // gosub MOVEdoorUP subroutine
  77. }
  78. //
  79. // check DOWN door Switch for status: = 1 NOT-DOWNcommandSWITCH / 0=DOWNcommandSWITCH
  80. DOWNDOORmode = P1.readDiscrete(DOWNcommandSWITCH); // check if DOWNcommandSWITCH = 1 NOT-DOWNcommandSWITCH / 0=DOWNcommandSWITCH
  81. if (DOWNDOORmode == 1) // check if DOWNDOORmode flag = 1 NOT- door down / 0= door down
  82. {
  83. MOVEdoorDOWN; // gosub MOVEdoorDOWN subroutine
  84. }
  85. //
  86. // check STOP door Switch for status: = 1 NOT-STOPcommandSWITCH / 0=STOPcommandSWITCH
  87. STOPDOORmode = P1.readDiscrete(STOPcommandSWITCH); // check if STOPcommandSWITCH = 1 NOT-STOPommandSWITCH / 0=STOPcommandSWITCH
  88. if (STOPDOORmode == 1) // check if STOPDOORmode flag = 1 NOT- door stop / 0= door stop
  89. {
  90. STOPdoor; // gosub STOPdoor subroutine
  91. }
  92.  
  93. P1.writeDiscrete(LOW, GREENlight); //green ight control= OFF
  94. delay(250); //wait .5 second
  95. }
  97. // **********************************************************************************
  98. // **********************************************************************************
  99. // move door up - start door movement UP
  100. //
  101. void MOVEdoorUP() // use void because variables declared globaly
  102. {
  103. P1.writeDiscrete(HIGH, AMBERlight); //amber light control 1= on
  104. P1.writeDiscrete(LOW,doorDOWNrelay); // doorDOWNrelay control relay 1=doorDOWN / 0=NOT-doorDOWN
  105. delay(250); //wait .25 second
  106. P1.writeDiscrete(HIGH,doorUPrelay); // doorUPrelay control relay 1=doorUP / 0=NOT-doorUP
  107. }
  109. // **********************************************************************************
  110. // **********************************************************************************
  111. // move door down - start door movement DOWN
  112. //
  113. void MOVEdoorDOWN() // use void because variables declared globaly
  114. {
  115. P1.writeDiscrete(HIGH, AMBERlight); //green light control 1= on
  116. P1.writeDiscrete(LOW,doorUPrelay); // doorUPrelay control relay 1=doorUP / 0=NOT-doorUP
  117. delay(250); //wait .25 second
  118. P1.writeDiscrete(HIGH,doorDOWNrelay); // doorUPrelay control relay 1=doorDOWN / 0=NOT-doorDOWN
  119. }
  121. // **********************************************************************************
  122. // **********************************************************************************
  123. // stop door - stop door movement
  124. //
  125. void STOPdoor() // use void because variables declared globaly
  126. {
  127. P1.writeDiscrete(LOW,doorUPrelay); // doorUPrelay control relay 1=doorUP / 0=NOT-doorUP
  128. P1.writeDiscrete(LOW,doorDOWNrelay); // doorDOWNrelay control relay 1=doorDOWN / 0=NOT-doorDOWN
  129. P1.writeDiscrete(LOW, GREENlight); //green light control 0= oFF
  130. }
  132. // **********************************************************************************
  133. // **********************************************************************************
  134.  
  135.  
  136. // **********************************************************************************

 

  • 2 answers
  • 93 views

  • Tinker (Customer)

    From: https://docs.arduino.cc/learn/programming/functions/ :

    "As you can see, even if a function does not have parameters and no returns is expected "(" and ")" brackets plus ";" must be given."

     

    Is the compiler giving any errors? I don't know off hand, what the compiler "thinks' of:

    1. {
    2. STOPdoor; // gosub STOPdoor subroutine
    3. }

    Note that in loop() you do call "scanCONTROLbuttons();" with the brackets

    Expand Post

  • FACTS_MikeSc (AutomationDirect)

    Yes without the () it's not a function call but an expression that refers to the function itself (its address). So it basically does nothing but it will compile.

     

    Just add the () to the function calls and you should be good.

 

Did this information resolve your issue?